Re: [RFC][v8][PATCH 4/10]: Add target_pid parameter to alloc_pidmap()

From: Pavel Emelyanov
Date: Tue Oct 13 2009 - 07:58:24 EST


Sukadev Bhattiprolu wrote:
>
> Subject: [RFC][v8][PATCH 4/10]: Add target_pid parameter to alloc_pidmap()
>

[ snip ]

> @@ -146,16 +146,22 @@ static int alloc_pidmap_page(struct pidm
> return 0;
> }
>
> -static int alloc_pidmap(struct pid_namespace *pid_ns)
> +static int alloc_pidmap(struct pid_namespace *pid_ns, int target_pid)

Please no! Better create another function, that will just
atomic_test_and_set() the proper bit in the map. This one
is heavy enough already.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/