Re: [PATCH 5/6 RFC] arch/m68knommu/kernel/process.c: Remove the BKLfrom sys_execve
From: Greg Ungerer
Date: Tue Oct 13 2009 - 06:45:52 EST
Hi John,
On 10/13/2009 08:34 AM, John Kacur wrote:
From e36c53d296132bc0ddbf6d9fb43ea5ea56dbd4a2 Mon Sep 17 00:00:00 2001
From: John Kacur<jkacur@xxxxxxxxxx>
Date: Mon, 12 Oct 2009 23:37:28 +0200
Subject: [PATCH] arch/m68knommu/kernel/process.c: Remove the BKL from sys_execve
This looks like a copy-and-paste of functionality that no-longer needs the bkl.
Just remove it.
Signed-off-by: John Kacur<jkacur@xxxxxxxxxx>
Tested and runs fine on m68knommu.
Acked-by: Greg Ungerer <gerg@xxxxxxxxxxx>
Do you want me to push this into the m68knommu git tree,
for eventual merging into Linus' tree? Or are you going
to push the whole set of patches together?
Regards
Greg
---
arch/m68knommu/kernel/process.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch/m68knommu/kernel/process.c b/arch/m68knommu/kernel/process.c
index 8f8f4ab..5c9ecd4 100644
--- a/arch/m68knommu/kernel/process.c
+++ b/arch/m68knommu/kernel/process.c
@@ -352,15 +352,12 @@ asmlinkage int sys_execve(char *name, char **argv, char **envp)
char * filename;
struct pt_regs *regs = (struct pt_regs *)&name;
- lock_kernel();
filename = getname(name);
error = PTR_ERR(filename);
if (IS_ERR(filename))
- goto out;
+ return error;
error = do_execve(filename, argv, envp, regs);
putname(filename);
-out:
- unlock_kernel();
return error;
}
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@xxxxxxxxxxxx
SnapGear Group, McAfee PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/