Re: [GIT PULL] tracing/kprobes: Syntax updates, introduce perfprobe

From: Ingo Molnar
Date: Tue Oct 13 2009 - 06:28:21 EST



* Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> On Tue, Oct 13, 2009 at 08:13:23AM +0200, Ingo Molnar wrote:
> >
> > * Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> >
> > > Ingo,
> > >
> > > I've tested a little this set and it seems to work well. I can't test
> > > the C expression parser (need some libdwarf cross-version
> > > compatiblity), but I can create kprobes via low-level parameters, then
> > > launch perf record and perf trace successfully. I'll need to update
> > > perf trace to handle variables that start with '$' characters though.
> > >
> > > Anyway, it's still unstable but I guess pulling it would help Masami
> > > to continue without the need to handle the whole batch.
> > >
> > > Please pull the tracing/kprobes branch that can be found at:
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
> > > tracing/kprobes
> >
> > Pulled, thanks Frederic.
> >
> > > Documentation/trace/kprobetrace.txt | 27 +-
> > > kernel/trace/trace_kprobe.c | 160 +++++---
> > > tools/perf/Makefile | 10 +
> > > tools/perf/builtin-probe.c | 386 +++++++++++++++++++
> > > tools/perf/builtin.h | 1 +
> > > tools/perf/perf.c | 1 +
> > > tools/perf/util/probe-finder.c | 690 +++++++++++++++++++++++++++++++++++
> > > tools/perf/util/probe-finder.h | 70 ++++
> > > 8 files changed, 1271 insertions(+), 74 deletions(-)
> > > create mode 100644 tools/perf/builtin-probe.c
> > > create mode 100644 tools/perf/util/probe-finder.c
> > > create mode 100644 tools/perf/util/probe-finder.h
> >
> > Hm, there's no x86 decoder change here - does this lot fixes the
> > instruction decoder bug i reported some time ago? That is which keeps
> > tracing/kprobes out of tip:master.
> >
> > Ingo
>
>
> Not yet, I hope it's part of the last family of instruction set we are
> missing.

ok.

We dont want topics to not be in tip:master for too long - we dont grow
conflict resolutions nor does it get tested widely.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/