Re: [PATCH 3/4] tracing/profile: Add filter support

[Ingo Molnar]

* Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:

> +#ifdef CONFIG_EVENT_PROFILE
> +struct perf_event;
> +extern int ftrace_profile_enable(int event_id);
> +extern void ftrace_profile_disable(int event_id);
> +extern int ftrace_profile_set_filter(struct perf_event *event, int event_id,
> +				     char *filter_str);
> +extern void ftrace_profile_free_filter(struct perf_event *event);
> +#endif

This reminds me - i think we should eliminate CONFIG_EVENT_PROFILE - 
it's an unnecessary Kconfig complication. If both PERF_EVENTS and 
EVENT_TRACING is enabled we should expose generic tracepoints.

Nor is it limited to event 'profiling', so it has become a misnomer as 
well.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/