Re: [tip:x86/cleanups] x86: use kernel_stack_pointer() in kprobes.c

[Masami Hiramatsu]

tip-bot for H. Peter Anvin wrote:
> Commit-ID:  98272ed0d2e6509fe7dc571e77956c99bf653bb6
> Gitweb:     http://git.kernel.org/tip/98272ed0d2e6509fe7dc571e77956c99bf653bb6
> Author:     H. Peter Anvin<hpa@xxxxxxxxx>
> AuthorDate: Mon, 12 Oct 2009 14:14:10 -0700
> Committer:  H. Peter Anvin<hpa@xxxxxxxxx>
> CommitDate: Mon, 12 Oct 2009 14:19:35 -0700
>
> x86: use kernel_stack_pointer() in kprobes.c
>
> The way to obtain a kernel-mode stack pointer from a struct pt_regs in
> 32-bit mode is "subtle": the stack doesn't actually contain the stack
> pointer, but rather the location where it would have been marks the
> actual previous stack frame.  For clarity, use kernel_stack_pointer()
> instead of coding this weirdness explicitly.
>
> Signed-off-by: H. Peter Anvin<hpa@xxxxxxxxx>
> Cc: Ananth N Mavinakayanahalli<ananth@xxxxxxxxxx>
> Cc: Anil S Keshavamurthy<anil.s.keshavamurthy@xxxxxxxxx>
> Cc: "David S. Miller"<davem@xxxxxxxxxxxxx>
> Cc: Masami Hiramatsu<mhiramat@xxxxxxxxxx>

Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

Thank you for fixing it!


--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@xxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/