Re: [PATCH tracing/kprobes v4] perf: Add perf probe subcommand forkprobe-event setup helper

[Masami Hiramatsu]

Frederic Weisbecker wrote:
> On Thu, Oct 08, 2009 at 05:17:38PM -0400, Masami Hiramatsu wrote:
> > +#ifdef DEBUG
> > +#define debug(fmt ...)	\
> > +	fprintf(stderr, "DBG(" __FILE__ ":" stringify(__LINE__) "): " fmt)
> > +#else
> > +#define debug(fmt ...)	do {} while (0)
> > +#endif
>
>
>
> We have that too:
>
> int eprintf(const char *fmt, ...) __attribute__((format(printf, 1, 2)));
> int dump_printf(const char *fmt, ...) __attribute__((format(printf, 1, 2)));

Thanks, I'll use that.

> > +#define ERR_IF(cnd)	\
> > +	do { if (cnd) {	\
> > +		fprintf(stderr, "Error (" __FILE__ ":" stringify(__LINE__) \
> > +			"): " stringify(cnd) "\n");			\
> > +		exit(1);						\
> > +	} } while (0)
>
>
> And that would be nice to have in util/debug.h but more
> perhaps more as a DIE_IF()

Sure :-)

Thank you,

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@xxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/