RE: [patch] Staging: hv: Fix vmbus load hang caused by wrong datapacking

[Haiyang Zhang]

>  	ChannelMessageCount
> -} __attribute__((packed));

Why the change here?  Isn't this doing the same thing?

And I'm guessing that not all of these structures are needing to be
packed, right?  Are they all shared across the HV boundry?

And is this fixing the problem that Hank and users have reported with
the current code?  Does this need to get into the 2.6.32 release?


thanks,

greg k-h
================================================
Hi Greg,

Based on our testing, the #pragma pack(push,1) can pack the data correctly for the HyperV to use, but __attribute__((packed)) couldn't do this right.

These data structures are moved by someone from the original file, ChannelMessages.h, which contains structures used for messaging to host.

Yes, it's fixing the problem that Hank and users have reported with the current code. And yes, 2.6.32 needs this fix.

Thanks,

- Haiyang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/