Re: [PATCH 1/2] rtc-ds1511: Fix races around device registration

[Alessandro Zummo]

On Tue, 13 Oct 2009 01:37:40 +0900
Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote:

> * Call dev_set_drvdata before rtc device creation
> * Use its own spinlock instead of rtc->irq_lock

 why?

> * Check pdata->rtc before calling rtc_update_irq
> * Use {alarm,update}_irq_enable and remove ioctl routine
> * Use devres APIs and simplify error/remove path

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/