Re: [origin tree build failure] [PATCH] Revert "USB: musb: make HAVE_CLK support optional"

[Mike Frysinger]

On Mon, Oct 12, 2009 at 03:42, Ingo Molnar wrote:
>
> * Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>> As usual, please test this for regressions, both new and old.
>
>> Â Â Â USB: musb: make HAVE_CLK support optional
>
> This USB/Blackfin commit broke the x86 build with these config options:
>
> ÂCONFIG_USB_MUSB_HDRC=y
> ÂCONFIG_USB_MUSB_HOST=y
> Â# CONFIG_USB_MUSB_PERIPHERAL is not set
> Â# CONFIG_USB_MUSB_OTG is not set
> Â# CONFIG_USB_GADGET_MUSB_HDRC is not set
> ÂCONFIG_USB_MUSB_HDRC_HCD=y
> ÂCONFIG_MUSB_PIO_ONLY=y
> ÂCONFIG_USB_MUSB_DEBUG=y
>
> Because a side-effect of the patch was that it enabled the driver on x86
> too which doesnt have HAVE_CLK. So this formerly embedded-only driver
> got exposed on the more widely tested x86 platform.

this is dumb.  you're addressing unrealistic scenarios (randconfig) by
reverting code for realistic scenarios.  how about updating the
already present arch depend string instead.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/