Re: [PATCH 1/9] KVM: SVM: Notify nested hypervisor of lost eventinjections

From: Avi Kivity
Date: Mon Oct 12 2009 - 05:35:50 EST


On 10/08/2009 06:46 PM, Alexander Graf wrote:


Am 08.10.2009 um 18:38 schrieb Avi Kivity <avi@xxxxxxxxxx>:

On 10/08/2009 06:32 PM, Joerg Roedel wrote:
No. The L1 guest needs to execute VMRUN with an interrupt to inject to
the L2 guest with event_inj. On that VMRUN instruction emulation an
interrupt becomes pending which causes an immediate #vmexit from L2 to
L2 again without even entering the L2 guest. The bug was that in this
case the event which the L1 tried to inject in the L2 was lost because
it was not copied to exit_int_info.


(from L1 to L0?)

Wow. Alex, how did you find this?

Hyper-V got stuck and I was trying to think of possible reasons looking at the logs :-).
Fortunately this patch also seemed to make things work better with KVM in KVM.

Doesn't really help with regression testing though...

We could write a dummy hypervisor that injects tons of interrupts and hope for a host interrupt in there. I'm worried about such a mass of complex code that gets very little testing.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/