Re: [PATCH] sound_core.c: Remove BKL from soundcore_open

[John Kacur]

On Mon, 12 Oct 2009, Takashi Iwai wrote:

> At Sun, 11 Oct 2009 14:41:15 +0200 (CEST),
> John Kacur wrote:
> > 
> > @@ -631,17 +629,17 @@ static int soundcore_open(struct inode *inode, struct file *file)
> >  		file->f_op = new_fops;
> >  		spin_unlock(&sound_loader_lock);
> >  		if(file->f_op->open)
> > +			lock_kernel();
> >  			err = file->f_op->open(inode,file);
> > +			unlock_kernel();
> 
> You certainly want braces around here, no?
> 

Oh, I don't know, I was kinda hoping that the spaces would magically 
impart bracketnishish to the whole thing. My God yes we want the brackets -
Thank you Takashi!

What follows is version four.