Re: USB serial regression 2.6.31.1 -> 2.6.31.2 [PATCH]

From: Alan Stern
Date: Sun Oct 11 2009 - 21:55:54 EST


On Mon, 12 Oct 2009, Benjamin Herrenschmidt wrote:

> Don't those devices support SANE_SENSE fine on LUN 0 according to
> Alan parsing of my traces ?

Not really; the device returned only the usual 18 bytes of sense data.
But at least it did so correctly instead of failing.

> Heh, they may even work if I actually
> populate the SD-CARD slot, I'll try later.

Possibly, but I sure wouldn't bet on it. :-)

> I still think it's simpler and potentially more future-proof to just
> have a back-off scenario.
>
> Now, whether we ping pong the US_FL_SANE_SENSE flag or not is minor,
> I tend to think that your approach that doesn't touch the flag might
> indeed be better.
>
> I'll test the patch later today.

And of course there remains the question of why the serial driver
wasn't loaded and probed. Would it make a difference if that driver
was already loaded when you plugged in the modem?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/