Re: [PATCH RFC] [PATCH] drivers/scsi/ch.c: Remove BKL in ch_open

From: Jonathan Corbet
Date: Sun Oct 11 2009 - 13:09:59 EST


On Sun, 11 Oct 2009 09:19:04 -0700
Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> > The more general problem of
> >
> > register_chrdev
> > open
> > do something
> > error
> > unload
> > whoops
> >
> > definitely needs looking at however.
>
> absolutely
>
> we used to have the same issue with networking devices,
> and there it ended up with a split "allocate" and "register"

Char devs are really the same way - request_chrdev_region() and
cdev_add(). I've thought for a while that register_chrdev() should be
seen as a legacy interface and removed - LDD3 was written from that
point of view. But that takes work, and nobody's found the issue
urgent enough to put time into...

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/