Re: [xfs-masters] INFO: possible circular locking dependencydetected

From: John Kacur
Date: Sun Oct 11 2009 - 12:01:25 EST




On Sun, 11 Oct 2009, Christoph Hellwig wrote:

> This has been around for a long time, the VM calls into fput and thus
> ->release with the mmap_sem held, which makes it really hard for a
> filesystem to avoid a lock inversion if it uses a lock both in ->release
> and the I/O path.
>
> I have a workaround for this to only acquire the XFS iolock with a
> trylock in the release path and leave cleaning up stale preallocations
> until the final iput. It's not pretty, but given that we're unlikely
> to see the VM fixed I might aswell finally send it for inclusion.
>

In seems very easy and reliable to reproduce on my machine - so I am happy
to test the patch here when you're ready.

Thanks

John
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/