Re: staging: where to put system-wide includes

From: Pavel Machek
Date: Fri Oct 09 2009 - 16:39:01 EST


On Thu 2009-10-08 14:40:27, Christoph Hellwig wrote:
> On Thu, Oct 08, 2009 at 01:28:18PM +0200, Pavel Machek wrote:
> > Hi!
> >
> > In staging, I need some includes that will become "system-wide" at the
> > end.
> >
> > Is it acceptable to create drivers/staging/include/linux (and
> > friends), and then use -I magic to include those headers?
>
> If you need system-wide inclusions it's pretty good sign that what
> you add is not a simple driver and thus should not just go into the
> staging tree. Given that you're a long-timer kernel hackers what's the
> problem with getting your code fully up to kernel standards anyway?

Well, it is not exactly my code -- I'm trying to merge HTC Dream
support. Problem with "simply cleaning it up" is that its 122Kloc.

Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/