Re: [PATCH] USB: serial: Fix read regression in 2.6.31.

From: Greg KH
Date: Fri Oct 09 2009 - 15:14:27 EST


On Fri, Oct 09, 2009 at 08:41:13PM +0200, Johan Hovold wrote:
> On Fri, Oct 09, 2009 at 10:56:02AM -0700, Greg KH wrote:
> > On Sun, Sep 20, 2009 at 10:18:36PM +0200, Johan Hovold wrote:
> > > Use ASYNCB_INITIALIZED to determine when to stop reading.
> > >
> > > Port count can no longer be used to determine when to stop reading from
> > > the device as it can be zero when the first read callbacks are made (see
> > > tty_port_block_til_read where port count is temporarily decremented
> > > during serial_open).
> > >
> > > Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx>
> > > ---
> > >
> > > Hi,
> > >
> > > Here's a patch which fixes the port count issue for all drivers. I only
> > > have access to an ftdi device at the moment so that's the only driver
> > > I've been able to test (against latest git with latest patches from
> > > Greg's tree).
> >
> > Hm, this doesn't apply on top of the other ftdi patches. Could you
> > respin this?
>
> There were some issues with that patch, so please disregard that one.
> Sorry. There are probably still some problems with some of the other
> drivers (at least theoretical ones) due to the tty changes that broke
> ftdi, but there is currently no patch to fix them all.

Ok, dropped :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/