Re: [PATCH 01/45] writeback: reduce calls to global_page_state inbalance_dirty_pages()

From: Jan Kara
Date: Fri Oct 09 2009 - 11:50:07 EST


On Fri 09-10-09 17:18:32, Peter Zijlstra wrote:
> On Fri, 2009-10-09 at 17:12 +0200, Jan Kara wrote:
> > Ugh, but this is not equivalent! We would block the writer on some BDI
> > without any dirty data if we are over global dirty limit. That didn't
> > happen before.
>
> It should have, we should throttle everything calling
> balance_dirty_pages() when we're over the total limit.
OK :) I agree it's reasonable. But Wu, please note this in the
changelog because it might be a substantial change for some loads.

Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/