Re: [PATCH 2/3] Fix memory leak of never putback pages in mbind()

From: Christoph Lameter
Date: Fri Oct 09 2009 - 09:56:34 EST


On Fri, 9 Oct 2009, KOSAKI Motohiro wrote:

> Oops, I forgot to remove unnecessary brace.
> updated patch is here.

Thats a style issue. There are other weird things in do_mbind as well
like starting a new block in the middle of another.

Having

}
{

in a program is a bit confusing. So could you do a cleanup patch for
mpol_bind? Preferably it should make it easy to read to and bring some
order to the confusing error handling.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/