Re: [PATCH] CS5535: Remove the X86 platform dependence ofSND_CS5535AUDIO

From: Andres Salomon
Date: Fri Oct 09 2009 - 01:06:34 EST


On Fri, 09 Oct 2009 11:51:27 +0800
Wu Zhangjin <wuzhangjin@xxxxxxxxx> wrote:

> On Fri, 2009-10-09 at 11:44 +0800, Wu Zhangjin wrote:
> > There is no platform dependence of SND_CS5535AUDIO before 2.6.31,
> > Not sure who have touched this part, but SND_CS5535AUDIO is at least
> > available on Loongson family machines, so, Remove the platform
> > dependence directly.
> >
> > Reported-by: rixed@xxxxxxxxxxxxxxx
> > Signed-off-by: Wu Zhangjin <wuzhangjin@xxxxxxxxx>
> > ---
> > sound/pci/Kconfig | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
> > index fb5ee3c..75c602b 100644
> > --- a/sound/pci/Kconfig
> > +++ b/sound/pci/Kconfig
> > @@ -259,7 +259,6 @@ config SND_CS5530
> >
> > config SND_CS5535AUDIO
> > tristate "CS5535/CS5536 Audio"
> > - depends on X86 && !X86_64
>
> or use this?
>
> depends on (X86 && !X86_64) || MIPS
>
> Regards,
> Wu Zhangjin
>


I'd say just remove the arch dependency (and make sure it builds and
doesn't obviously explode w/ x86-64). There's no need for it, afaict.
It's been there since at least 2005 (git commit 230b5c1a).


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/