Re: [PATCH] net: Add netdev_alloc_skb_ip_align() helper

From: Thomas Chou
Date: Thu Oct 08 2009 - 00:37:29 EST


On 10/08/2009 11:11 AM, Eric Dumazet wrote:
Thomas Chou a écrit :
You should do :

size -= 4; /* strip the CRC */
skb = netdev_alloc_skb(dev, size + NET_IP_ALIGN);
if (skb) {
skb_reserve(skb, NET_IP_ALIGN);
...
}


Please check other implementations...

David, maybe we should add following helper :

[PATCH] net: Add netdev_alloc_skb_ip_align() helper

Hi Eric,

Thanks for the suggestion. I will follow your commit and send revised patch.

- Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/