Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not used

From: David Howells
Date: Tue Sep 29 2009 - 14:41:04 EST


Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> Comments?

Perhaps add legacy pty support to the list of features to be removed and see
who howls.

> static struct tty_driver *pty_driver, *pty_slave_driver;

These shouldn't be global variables. They're only used within
legacy_pty_init(). That's a side issue, however.

Apart from that, it looks reasonable.

Acked-by: David Howells <dhowells@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/