Re: [origin tree build failure] Re: [PULL] Please pull hwpoison code for 2.6.32

From: Andi Kleen
Date: Sat Sep 26 2009 - 13:28:22 EST


On Sat, Sep 26, 2009 at 10:20:05AM -0700, H. Peter Anvin wrote:
> It doesn't help adjusting NODES_SHIFT - we're already operating in the stressed condition for which NODES_WIDTH == 0 (external node number.)
>
> As such, NUMA vs !NUMA is a red herring - it's really about SPARSEMEM.
>
> (Disclaimer: I have no access to the code at the moment and I only have my cell phone email, but I had to deal with this for another issue recently enough.)

You're right. In theory we could just set the sparsemem block really
large on NUMAQ because it doesn't support memory hotadd anyways, so needing
less bits. But Linus' simple patch is also a solution.

Of course the issue might come up again when someone else needs another
page flags bit.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/