Re: [origin tree boot hang] [PATCH] Revert "early_printk: Allowmorethanone early console"

[Jason Wessel]

Ingo Molnar wrote:
> * Ingo Molnar <mingo@xxxxxxx> wrote:
>
>
>   
>> The commit point to which the attached config and bootlog belongs is:
>>
>>   2.6.31-07863-gb64ada6
>>
>> Reverting:
>>
>>   c953094: early_printk: Allow more than one early console
>>
>> solves it.
>>     
>
> btw., the boot options are:
>
> Command line: root=/dev/sda6 earlyprintk=serial,ttyS0,115200 console=ttyS0,115200 debug
> initcall_debug apic=verbose sysrq_always_enabled ignore_loglevel 
> selinux=0 nmi_watchdog=0 panic=1 3
>
>   

AH HA!

earlyprintk=serial,ttyS0,115200

You are invoking the same device twice which is why you are having infinite recursion.  It was not obvious to me why the earlyprintk code would allow "serial" or "ttyS", but perhaps we need to protect for that?

Your boot line should be:

earlyprintk=serial,115200

OR

earlyprintk=ttyS0,115200

The line you had there before would have been the equivalent of doing:

earlyprintk=ttyS0,ttyS0,115200

Given this, do we still need to execute the revert your revert?  Or perhaps do we need to add some protection?

Thanks,
Jason.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/