Re: [PATCH 1/2] Add COH 901 318 DMA block driver

[Daniel Walker]

On Tue, 2009-09-22 at 16:38 +0200, Linus Walleij wrote:
> +       val &= ~COH901318_CX_CFG_CH_ENABLE;
> +       writel(val, virtbase + COH901318_CX_CFG +
> +              COH901318_CX_CFG_SPACING * channel);
> +
> +       writel(val, virtbase + COH901318_CX_CFG +
> +              COH901318_CX_CFG_SPACING * channel);
> +       wmb();
> +
> +       /* Spin-wait for it to actually go inactive */
> +       while (readl(virtbase + COH901318_CX_STAT+COH901318_CX_STAT_SPACING *
> +                    channel) & COH901318_CX_STAT_ACTIVE) {}

You might want to add a cpu_relax() here ..

Daniel



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/