Re: [lm-sensors] coretemp support for Core i5 CPU
From: Jean Delvare
Date: Mon Sep 21 2009 - 03:50:17 EST
On Sun, 20 Sep 2009 16:53:53 -0600, Robert Hancock wrote:
> On Sun, Sep 20, 2009 at 1:16 PM, Jean Delvare <khali@xxxxxxxxxxxx> wrote:
> > Supporting the digital thermal sensor is one thing, but it is totally
> > insufficient. If you look at the coretemp driver, you'll see we need to
> > figure out a number of calibration values which are model-dependent. So
> > we will need to check this part before adding support for new CPU
> > models anyway.
>
> Well, I see there is the TCC activation temperature which the reading
> is relative to, which is detected on the mobile CPUs via an MSR read,
> so it would only be a problem if they changed this temperature on
> other CPUs..
They actually did change it on almost every CPU model so far. I fail to
see why that would suddenly change (even though I'd really love it.)
> It might make sense to warn "unknown CPU model, temperature reading
> may be suspect" or something, but I should think it should still load
> as the temperature reading is likely still correct.
Our experience is the exact opposite. The temperature reading is likely
not correct. And we prefer not telling the user anything than to tell
him/her something incorrect. Most users won't notice warnings in their
kernel logs, all they see is a CPU temperature value in their desktop
tray area.
I hope Intel will finally take over the driver maintenance and deal
with their own mess. It has been a pain for us to maintain since day 2.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/