Re: [PULL] http://www.kernellabs.com/hg/~stoth/saa7164-merge

[Mauro Carvalho Chehab]

Em Thu, 03 Sep 2009 23:35:29 -0400
Steven Toth <stoth@xxxxxxxxxxxxxx> escreveu:

> Hello Mauro,
> 
> This patch series adds support for the NXP SAA7164 PCIe A/V bridge used by the 
> Hauppauge HVR-2200 and HVR-2250 series of products. Support is limited to DVB-T 
> / ATSC / QAM digital TV only. The driver has been in development (on and off) 
> for around a year and the KernelLabs saa7164-stable tree (from which this patch 
> set was prepared) has been in testing worldwide since approx May(?) 2009.
> 
> The project page including links for firmware downloads, MythTV and Wiki 
> instructions is here: http://www.kernellabs.com/blog/?page_id=17
> 
> Two general observations with the tree:
> 
> 1. The driver is a little verbose during initial module load, I need to trim a 
> few lines of debug.
> 2. During 64bit compile I have one compile time warning to be addressed.
> 
> Both of these will be resolved shortly and should not stop the driver being 
> merged and made available to a much wider range of testers.
> 
> So, please pull from http://www.kernellabs.com/hg/~stoth/saa7164-merge

> SAA7164: Fix i2c eeprom read errors during load (some boards).
> From: Steven Toth <stoth@xxxxxxxxxxxxxx>
> SAA7164: Fix i2c eeprom read errors during load (some boards).
> Priority: normal
> Signed-off-by: Steven Toth <stoth@xxxxxxxxxxxxxx>

Please don't repeat the one-line summary as description. There are several cases like the above.

>     -  Add the SAA7164 I2C bus identifier

--- a/linux/include/linux/i2c-id.h      Thu Sep 03 09:06:34 2009 -0300
+++ b/linux/include/linux/i2c-id.h      Sat May 09 12:24:12 2009 -0400

+#define I2C_HW_B_SAA7164        0x010024 /* NXP 7164 based tv cards */

Why? Are you needing to use this constant somewhere? If not, just drop it and
leave the field in blank.

Anyway, I won't delay applying it due to that. I'm committing the series. Please send a fix
later for the i2c-id above mentioned.

Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/