Re: [RFC][PATCH] LED driver for Intel NAS SS4200 series

[Richard Purdie]

On Tue, 2009-09-15 at 13:38 -0700, Dave Hansen wrote:
> This code is based on a driver that came in the "Open-source
> and GPL components" download here:
>     
> http://downloadcenter.intel.com/SearchResult.aspx?lang=eng&ProductFamily=Server+Products&ProductLine=Intel%C2%AE+Storage+Systems&ProductProduct=Intel%C2%AE+Entry+Storage+System+SS4200-E&OSVersion=OS+Independent
>     
> It was in a file called nasgpio.c inside of a second zip file
> called SS4200-E_Linux_SIO_Driver-v1.4.zip.
> 
> That code used an ioctl() call to operate the LEDs.  It also
> created a new top-level /proc file just to let userspace locate
> which dynamic major number had been allocated to the device.
> I decided that the interface probably wasn't mergeable in that
> form. :)
>     
> I ripped out all of the hardware monitor support from nasgpio.c
> as well as the smbus code that controls the LED brightness.  I
> then converted the code to use the existing LED interfaces
> rather than the ioctl().  I don't have any need for brightness
> control, and its code is *completely* separate from the on/off
> controls implemented here.  If anyone else wants it, I'd be
> happy to look into adding it, but I don't care enough for now.

At a quick review this looks good. One question: These LEDs appear to be
attached to generic GPIOs on a southbridge that is probably in other
devices? If so, how do we know they're connected to LEDs? Do we need to
add some further check of what kind of device we're running on?

Cheers,

Richard

-- 
Richard Purdie
Intel Open Source Technology Centre

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/