Re: [PATCH 06/20] mem_class: use minor as index instead of searching the array

From: Kay Sievers
Date: Tue Sep 15 2009 - 15:47:00 EST


On Tue, Sep 15, 2009 at 21:42, Daniel Walker <dwalker@xxxxxxxxxx> wrote:
> On Tue, 2009-09-15 at 12:12 -0700, Greg Kroah-Hartman wrote:
>> +static const struct memdev {
>> + Â Â Â const char *name;
>> + Â Â Â const struct file_operations *fops;
>> + Â Â Â struct backing_dev_info *dev_info;
>> +} devlist[] = {
>> + Â Â Â [ 1] = { "mem", &mem_fops, &directly_mappable_cdev_bdi },
>
> This patch has several checkpatch errors wrt. the spacing used in the
> array index..
>
> Kay, can you send a follow up patch to correct them?

I think they are fine, and properly aligned to be best readable.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/