Re: [patch 1/5] fs: make use of rcu helpers

[Jens Axboe]

On Wed, Sep 16 2009, npiggin@xxxxxxx wrote:
> list_add_tail_rcu contains required barriers.

Thanks, applied as well.

> 
> Signed-off-by: Nick Piggin <npiggin@xxxxxxx>
> ---
>  fs/fs-writeback.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> Index: linux-2.6/fs/fs-writeback.c
> ===================================================================
> --- linux-2.6.orig/fs/fs-writeback.c
> +++ linux-2.6/fs/fs-writeback.c
> @@ -152,11 +152,6 @@ static void bdi_queue_work(struct backin
>  		atomic_set(&work->pending, bdi->wb_cnt);
>  		BUG_ON(!bdi->wb_cnt);
>  
> -		/*
> -		 * Make sure stores are seen before it appears on the list
> -		 */
> -		smp_mb();
> -
>  		spin_lock(&bdi->wb_lock);
>  		list_add_tail_rcu(&work->list, &bdi->work_list);
>  		spin_unlock(&bdi->wb_lock);
> 
> 

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/