Re: [PATCH] arm: remove unused code in delay.S

[Felipe Contreras]

On Tue, Sep 15, 2009 at 7:30 PM, Steve Chen <schen@xxxxxxxxxx> wrote:
> On Tue, 2009-09-15 at 15:41 +0200, Marek Vasut wrote:
>> > -#if 0
>> > +#if CONFIG_OLD_CPU_DELAY
>>
>> ifdef please
>>
> I assume this a vote in favor of considering this patch as an
> alternative :) ÂThe updated patch is below. ÂSince I'm only summarizing
> the e-mail thread and put them into a patch (which is a less time
> consuming process than continue reading and deleting e-mails on this
> thread), contributors can add signed off before submitting to Russel.
>
> Document #if 0 code block in delay.S and make it selectable for compile.

Nice :)

A few nitpicks though:

> Signed-off-by: Steve Chen <schen@xxxxxxxxxx>
>
> ---
>
> Âarch/arm/Kconfig   |  Â8 ++++++++
> Âarch/arm/lib/delay.S | Â Â2 +-
> Â2 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index aef63c8..ca8d535 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -813,6 +813,14 @@ config ARM_ERRATA_460075
> Â Â Â Â ÂACTLR register. Note that setting specific bits in the ACTLR
> register
> Â Â Â Â Âmay not be available in non-secure mode.
>
> +config OLD_CPU_DELAY
> + Â Â Â depends on CPU_32v3 || CPU_32v4 || CPU_32v4T
> + Â Â Â bool "Accurate delays for older CPU"

s/older CPU/old CPUs/

Or even better, since this option will only appear on older CPUs:
"Accurate delays"

> + Â Â Â def_bool n
> + Â Â Â help
> + Â Â Â Â Enable if observing longer than expected delays and need more
> + Â Â Â Â accurate delays on older CPUs.

How about:
> +         Enable if observing longer than expected delays and need more
> +         accuracy. This should only be considered for old CPUs (e.g. foo, bar).

Cheers.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/