Re: [PATCH 11/11] Use unreachable() in asm-generic/bug.h for !CONFIG_BUG case.

From: Linus Torvalds
Date: Mon Sep 14 2009 - 19:40:37 EST




On Mon, 14 Sep 2009, David Daney wrote:
>
> The existing code just falls through to whatever happens to follow the BUG().

Brian was talking BUG_ON().

And the existing !CONFIG_BUG BUG_ON() is actually set up so that gcc will
just optimize it away entirely (yet give the same compile-time warnings as
the "real" BUG_ON() does).

Changing it to "if (cond) unreachable()" is likely to generate _more_
code, which is against the whole point of wanting to disable CONFIG_BUG.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/