Re: [PATCH] drm/radeon/kms: R3XX/R4XX AGP asic use PCI GART notPCIE GART

[Andrew Morton]

On Thu, 10 Sep 2009 13:47:09 +0200
Jerome Glisse <jglisse@xxxxxxxxxx> wrote:

> R3XX/R4XX AGP asic use the old PCI GART block, not the new PCIE GART.
> Make sure we pick the right GART when disabling AGP.
> 

This patch doesn't apply to 2.6.31.  It's not completely trivial to fix
either - these declarations

+ void r100_pci_gart_tlb_flush(struct radeon_device *rdev);
+ int r100_pci_gart_enable(struct radeon_device *rdev);
+ void r100_pci_gart_disable(struct radeon_device *rdev);
+ int r100_pci_gart_set_page(struct radeon_device *rdev, int i, uint64_t addr);

would naturally lie in radeon_asic.h but we can't do that because some
stupidhead went and put this:

static struct radeon_asic r100_asic = {

into a .h file, making that header file unusable for the things which
header files are used for.


So please have another go.

If you believe that the the patch is suitable for backporting into 2.6.31.x
then please

- cc stable@xxxxxxxxxx on the patch

- add a `Cc: <stable@xxxxxxxxxx>' to the changelog

- ensure that the changelog text explains to the -stable maintainers why
  this patch should be backported.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/