Re: [PATCH 00/72] Blackfin updates for 2.6.32

From: Mike Frysinger
Date: Mon Sep 14 2009 - 17:07:59 EST


On Mon, Sep 14, 2009 at 17:04, Daniel Walker wrote:
> On Mon, 2009-09-14 at 16:57 -0400, Mike Frysinger wrote:
>> On Mon, Sep 14, 2009 at 16:50, Daniel Walker wrote:
>> > On Mon, 2009-09-14 at 16:07 -0400, Mike Frysinger wrote:
>> >> Minor highlights:
>> >> Â- shadow console to help with really early kernel output
>> >> Â- proper decoding of double fault handling
>> >>
>> >> Otherwise, we've got the normal bug fixes, IPIPE updates, and clean ups.
>> >>
>> >
>> > Patches 15, 16, 20, 21, and 61 all have checkpatch errors some with
>> > several errors.. ÂCould you clean those up those errors before sending
>> > this up stream?
>>
>> i already checked/reviewed the output in the series
>
> The remaining problems can be fixed .. Why did you leave those errors ?

i'm not going to sweat 80 col warnings when the line is 81 cols with
tabs of 8 spaces

as for the other errors, you probably didnt read the code. you saw
"error" and assumed checkpatch was correct. it isnt always as it isnt
a C parser.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/