Re: PATCH] cpuidle: A new variant of the menu governor to boost IOperformance

[Arjan van de Ven]

On Mon, 14 Sep 2009 00:43:01 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> 
> static DEFINE_PER_CPU(struct menu_device, menu_devices);
> 
> in both menu.c and menu-tng.c.
> 
> Despite the `static', the percpu changes in
> 
> commit 7c756e6e19e71f0327760d8955f7077118ebb2b1
> Author:     Tejun Heo <tj@xxxxxxxxxx>
> AuthorDate: Wed Jun 24 15:13:50 2009 +0900
> Commit:     Tejun Heo <tj@xxxxxxxxxx>
> CommitDate: Wed Jun 24 15:13:50 2009 +0900
> 
>     percpu: implement optional weak percpu definitions
> 
> are emitting global symbol derived from `menu_devices' and they clash.
> 
> 
> I'll rename menu_devices to fix that up, but we have a problem...

I would consider "static" not working a problem...
yes here it's easy to fix, but it's not nice if you can't make .c file
private..


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/