Re: [PATCH v4] ftrace: document basic ftracer/ftracer graph needs

[Mike Frysinger]

On Mon, Sep 14, 2009 at 15:48, Steven Rostedt wrote:
> On Sat, 2009-06-13 at 23:05 -0400, Mike Frysinger wrote:
>> diff --git a/Documentation/trace/ftrace.txt b/Documentation/trace/ftrace.txt
>> index fd9a3e6..95a39fb 100644
>> --- a/Documentation/trace/ftrace.txt
>> +++ b/Documentation/trace/ftrace.txt
>> @@ -27,6 +27,12 @@ disabled, and more (ftrace allows for tracer plugins, which
>> Âmeans that the list of tracers can always grow).
>>
>>
>> +Implementation Details
>> +----------------------
>> +
>> +See ftrace-implementation.txt for details for arch porters and such.
>
> Might want to specify that this is for the function tracer.

well, all of ftrace.txt says "function tracer", so if/when someone
cleans that up, this will get fixed in the process.

>> --- a/kernel/trace/Kconfig
>> +++ b/kernel/trace/Kconfig
>> @@ -11,31 +11,41 @@ config NOP_TRACER
>>
>> Âconfig HAVE_FTRACE_NMI_ENTER
>> Â Â Â bool
>> + Â Â help
>> + Â Â Â See Documentation/trace/ftrace-implementation.txt
>>
>> Âconfig HAVE_FUNCTION_TRACER
>> Â Â Â bool
>> + Â Â help
>> + Â Â Â See Documentation/trace/ftrace-implementation.txt
>>
>> Âconfig HAVE_FUNCTION_GRAPH_TRACER
>> Â Â Â bool
>> + Â Â help
>> + Â Â Â See Documentation/trace/ftrace-implementation.txt
>>
>> Âconfig HAVE_FUNCTION_TRACE_MCOUNT_TEST
>> Â Â Â bool
>> Â Â Â help
>> - Â Â ÂThis gets selected when the arch tests the function_trace_stop
>> - Â Â Âvariable at the mcount call site. Otherwise, this variable
>> - Â Â Âis tested by the called function.
>> + Â Â Â See Documentation/trace/ftrace-implementation.txt
>>
>> Âconfig HAVE_DYNAMIC_FTRACE
>> Â Â Â bool
>> + Â Â help
>> + Â Â Â See Documentation/trace/ftrace-implementation.txt
>>
>> Âconfig HAVE_FTRACE_MCOUNT_RECORD
>> Â Â Â bool
>> + Â Â help
>> + Â Â Â See Documentation/trace/ftrace-implementation.txt
>>
>> Âconfig HAVE_HW_BRANCH_TRACER
>> Â Â Â bool
>>
>> Âconfig HAVE_FTRACE_SYSCALLS
>> Â Â Â bool
>> + Â Â help
>> + Â Â Â See Documentation/trace/ftrace-implementation.txt
>>
>> Âconfig TRACER_MAX_TRACE
>> Â Â Â bool
>
> Other than this, it looks good.

so you want me to drop the Kconfig pieces ?  there was discussion in
this thread about why the Kconfig pieces were here ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/