Re: [crash, bisected] Re: clocksource: Resolve cpu hotplug deadlock with TSC unstable

From: Martin Schwidefsky
Date: Mon Sep 14 2009 - 11:37:29 EST


On Mon, 14 Sep 2009 17:19:58 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:

> Now another box crashes during bootup. Reverting these two:
>
> f79e025: clocksource: Resolve cpu hotplug dead lock with TSC unstable, fix crash
> 7285dd7: clocksource: Resolve cpu hotplug dead lock with TSC unstable
>
> allows me to boot it.
>
> plain 32-bit defconfig.

I've seen the bug report. init_workqueues comes after smp_init.
The idea I'm currently playing with is a simple check in the tsc
code if the tsc clocksource is already registered or not.
When smp_init is called the tsc is not yet registered, we could
just set the rating to zero.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/