Re: [PATCH] hwmon: Driver for SCSI/ATA temperature sensors

[Pavel Machek]

Hi!

> Finally, this:
> 
> > +               if (attr[2] == 194) {
> > +                       *temp = attr[7] * 1000;
> > +                       err = 0;
> > +                       break;
> 
> Smart attribute 194 is highly vendor specific ... for instance my new
> SATA drive doesn't implement it (it does implement 190 instead).
> 
> So really, given the complexity of just obtaining the data and the
> problem of matching which data to obtain to which device you have, why
> not just use smartctl from userspace for monitoring?  you could even
> just plug into smartd, it seems to have most of the necessary heuristics
> built in already.


Well, having unified kernel<->user interface for temperature sensors
makes sense.

I'm not sure if benefits outweight costs here (I tend to think they
do), but...
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/