Re: [PATCH 3/3] dell-laptop: fix rfkill memory leak on unload

From: Corentin Chary
Date: Mon Sep 14 2009 - 08:02:04 EST


On Monday 14 September 2009 13:02:39 Alan Jenkins wrote:
> Matthew Garrett wrote:
> > On Mon, Sep 14, 2009 at 12:43:53PM +0200, Corentin Chary wrote:
> >> rfkill_unregister() should always be followed by rfkill_destroy()
> >>
> >> Cc: Matthew Garrett <mjg@xxxxxxxxxx>
> >> Signed-off-by: Corentin Chary <corentincj@xxxxxxxxxx>
> >
> > Acked-by: Matthew Garrett <mjg@xxxxxxxxxx>
>
> I can endorse this as I already submitted something similar :-).
> <http://patchwork.kernel.org/patch/42699/> (with a disclaimer that it
> was not tested on dell hardware).

I haven't seen your patch, sorry :/

It also conflicts with http://patchwork.kernel.org/patch/42705/ (I set
wlan_rfkill to NULL to avoid use-after-free).

Let's drop this patch and merge your series

--
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/