Re: UWB Kconfig: cannot set UWB to N in gconfig

[David Vrabel]

Richard Kennedy wrote:
> I sometimes use 'make gconfig' and I noticed that I cannot disable the
> UWB option -- it just won't let me set it to N.
> 
> AFAICT this is because the CONFIG USB_WUSB selects UWB which forces it
> on.
> applying this patch fixes the issue but I'm not sure if this is the
> right way to go about it.
> 
> any thoughts?
> 
> regards
> Richard
> 
> This is against 2.6.31
> 
> 
> diff --git a/drivers/usb/wusbcore/Kconfig b/drivers/usb/wusbcore/Kconfig
> index eb09a0a..cc97041 100644
> --- a/drivers/usb/wusbcore/Kconfig
> +++ b/drivers/usb/wusbcore/Kconfig
> @@ -5,7 +5,7 @@ config USB_WUSB
>  	tristate "Enable Wireless USB extensions (EXPERIMENTAL)"
>  	depends on EXPERIMENTAL
>  	depends on USB
> -        select UWB
> +        depends on UWB

NAK.  It's not sufficiently obvious to a user that Wireless USB support
requires UWB.

This is really an issue with the configuration application.  Consider
improving them to allow switching off select'ed options and popping up a
dialog that says "switching off UWB will also switch off WUSB" etc.

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/