Re: [PATCH 2/5] kbuild: fix warning when domainname is not available

[Felipe Contreras]

On Mon, Sep 14, 2009 at 12:12 AM, Mike Frysinger <vapier.adi@xxxxxxxxx> wrote:
> On Sun, Sep 13, 2009 at 15:38, Felipe Contreras wrote:
>> + Âif $domain; then
>
> is this really correct ? Âi think you meant to use:
> [ -n "$domain" ]

What is the difference?

$domain unset
test -n "" -> false
test -> false

$domain is a valid string
test -n "string" -> true
test "string" -> true

The relevant rules are these:
* An omitted EXPRESSION defaults to false
* STRING equivalent to -n STRING

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/