Re: [PATCH 2/8] drivers/media/video/uvc: introduce missing kfree

[Julia Lawall]

> > -	if ((stream->dev->quirks & UVC_QUIRK_PROBE_DEF) && query == UVC_GET_DEF)
> > -		return -EIO;
> > +	if ((stream->dev->quirks & UVC_QUIRK_PROBE_DEF) &&
> > +			query == UVC_GET_DEF) {
> > +		ret = -EIO;
> > +		goto out;
> > +	}
> 
> This check can be moved before kmalloc(), removing the need to free memory in 
> case of error.
> 
> Julia, do you want to submit a modified patch or should I do it myself ?

I can do it.  I will send a revised patch shortly.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/