Re: [GIT PULL] x86/xen for v2.6.32

[Jesper Juhl]

On Sat, 12 Sep 2009, Ingo Molnar wrote:

> 
> * Jesper Juhl <jj@xxxxxxxxxxxxx> wrote:
> 
[...]
> > 
> > Why is this cast of 'va' needed?  As far as I can see, 'va' already has 
> > the correct type of "unsigned long".
> > Pointless casts do more harm than good, let's remove this one :-)
> > 
> > Sorry that all I could comment on was this trivial thing, but I thought it 
> > better to comment than keep silent now that I had read the patch and 
> > spotted it...
> 
> Yes, that cast could be removed.
> 
> Btw., i'd suggest that if you have trivial review feedback please 
> comment on the originating patches, in the original, finegrained 
> context, not the summary pull request. (Incidentally i did that too 
> there and the above patches did result in a few cleanups when they 
> were submitted.)
> 
> The reason is that the originating threads all have full changelogs 
> and have all the right people Cc:-ed in general - and by reviewing 
> them you will also influence the patches before they are sent to 
> Linus. The pull requests have Linus and the affected maintainers 
> Cc:-ed mainly. So for example you did not Cc: Jeremy to the x86/fpu 
> pull request comments you did so he had no chance to comment on them 
> unless he happened to run across your comments on lkml.
> 
> Bug/crash reports and serious gotcha feedback can go to the pull 
> requests too just fine - but even then, if you know what the 
> originating commit is, try to include the people who originated the 
> commit. (And feel free to Cc: Linus to that trivial feedback if you 
> think it's important enough.)
> 

You are making a lot of sense Ingo. I'll try to remember that.


-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>             http://www.chaosbits.net/
Plain text mails only, please      http://www.expita.com/nomime.html
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/