Re: [PATCH] fs: Make sure data stored into inode is properly seenbefore unlocking new inode

From: Al Viro
Date: Sat Sep 12 2009 - 11:06:51 EST


On Tue, Sep 08, 2009 at 01:41:03PM +0200, Jan Kara wrote:
> In theory it could happen that on one CPU we initialize a new inode but clearing
> of I_NEW | I_LOCK gets reordered before some of the initialization. Thus on
> another CPU we return not fully uptodate inode from iget_locked().
>
> This seems to fix a corruption issue on ext3 mounted over NFS.

Nice catch. ACK.

> Since Al doesn't seem to be online, does anybody else have opinion on this
> patch? I can merge it via my tree but I'd like to get a review from someone
> else.

I'm back, actually, and finally had almost crawled from under the pile
of mail in mbox. Will apply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/