Re: [PATCH][mmotm][BUGFIX] kcore use registered physmem information ia64-fix (Was Re: mmotm 2009-09-03-16-35 uploaded

From: KOSAKI Motohiro
Date: Thu Sep 10 2009 - 21:25:25 EST


> Ok, I confirmed this one fixes the issue.

mmotm-2009-09-09 + this patch booted successful on my box.

Tested-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>

Andrew, could you please pick it up?



> ==
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> kcore-use-registerd-physmem-information.patch registers physmem information
> based on ioresource. Then, this addition is unnecessary.
>
> Why panic:
> At boot, rebuilding kclist for physmem, all KCORE_RAM entries are kfreed.
> Because this ramaining one entires kclist of KCORE_RAM in kernel data area
> to ther list, this causes panic in kclist rebuilding which calls kfree().
>
> Reported-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> ---
> arch/ia64/mm/init.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> Index: mmotm-2.6.31-Sep3/arch/ia64/mm/init.c
> ===================================================================
> --- mmotm-2.6.31-Sep3.orig/arch/ia64/mm/init.c
> +++ mmotm-2.6.31-Sep3/arch/ia64/mm/init.c
> @@ -617,7 +617,6 @@ mem_init (void)
> long reserved_pages, codesize, datasize, initsize;
> pg_data_t *pgdat;
> int i;
> - static struct kcore_list kcore_mem;
>
> BUG_ON(PTRS_PER_PGD * sizeof(pgd_t) != PAGE_SIZE);
> BUG_ON(PTRS_PER_PMD * sizeof(pmd_t) != PAGE_SIZE);
> @@ -639,8 +638,6 @@ mem_init (void)
>
> high_memory = __va(max_low_pfn * PAGE_SIZE);
>
> - kclist_add(&kcore_mem, __va(0), max_low_pfn * PAGE_SIZE, KCORE_RAM);
> -
> for_each_online_pgdat(pgdat)
> if (pgdat->bdata->node_bootmem_map)
> totalram_pages += free_all_bootmem_node(pgdat);
>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/