Re: [PATCH 1/3] agp/intel: remove restore in resume

From: Zhenyu Wang
Date: Thu Sep 10 2009 - 21:04:34 EST


On 2009.09.10 13:42:52 -0700, Andrew Morton wrote:
> On Fri, 4 Sep 2009 09:43:34 +0800
> Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx> wrote:
>
> > As early pci resume has already restored config for host
> > bridge and graphics device, don't need to restore it again,
> > which might cause problem on some chips, like 845G tested by
> > Alan Stern.
> >
> > Cc: Stable Team <stable@xxxxxxxxxx>
> > Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>
>
> Why were these patches cc'ed to stable@xxxxxxxxxx? There's nothing in
> the changelog which explains why the problem which is being fixed is
> sufficiently serious to warrant backporting the patch.

Sorry, Andrew. I wasn't awared that an earlier version of this patch
has already been merged, and this patch fixed resume issue on Alan's
845G, which was discussed on linux-pm list, I should have made more
clear note about that. We've also seen other resume failure bugs, which
might be relate to this one. So I think it should be fine for stable.

>
> Was there a [patch 3/3]? I didn't receive it.

sorry, my mistake, the 3/3 commit on my tree is not ready to send,
forget to make git format-patch happy.

--
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

Attachment: signature.asc
Description: Digital signature