Re: [PATCH] update clocksource raw_time in timekeeping_suspend

[john stultz]

On Thu, 2009-09-10 at 17:31 +0800, Yong Zhang wrote:
> On Thu, Sep 10, 2009 at 4:07 PM, ye janboe <janboe.ye@xxxxxxxxx> wrote:
> > hi, John
> >
> > Thanks for your comments.
> >
> > After sent this patch, I realize that this patch exposes the hardware
> > detail ugly in common code.
> >
> > In embed system, user space apps need to have a method to get the
> > right time which will not be impacted by NTP and suspend.
> >
> > Yes, you are right. I want to add sleep_length to the raw time and
> > user space apps could get the right time after suspend.
> >
> 
> What I get from the code is that CLOCK_MONOTONIC doesn't consider
> sleep_length either. Do I miss something?

You're quite right. I forgot we drop sleep_length from
wall_to_monotonic, so it should not increase while we're suspended.

Janboe: So I think things are fine as they stand. No patch necessary.

But please let me know if I'm yet again forgetting something or you're
finding CLOCK_MONOTONIC_RAW to be insufficient in some way.

thanks
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/