Re: [PATCH] char/tty_io: fix legacy pty name when more than 256 ptydevices are requested

From: Mauro Carvalho Chehab
Date: Thu Sep 10 2009 - 15:13:01 EST


Em Thu, 10 Sep 2009 09:08:39 -0700
"H. Peter Anvin" <hpa@xxxxxxxxx> escreveu:

> On 09/10/2009 07:07 AM, Alan Cox wrote:
> >
> > This is a real step back.
> >
> > It now wastes all the tty[e-p]%d namespace. ttyp%d for > 255 at least
> > only uses one for this irrelevant area.
> >
>
> Honestly, I *really* don't think the [pt]ty[p-za-e]* namespace should be
> used for another purpose, at least until BSD ptys are killed dead, so in
> that sense expanding tty[p-za-e][0-9a-f] to tty[p-za-e][0-9a-f]+ is
> hardly significant in the namespace pollution sense. Can you imagine
> ttyp1 being a BSD pty and ttyp10 being a completely different kind of
> device?

+1. Reusing the namespace after tty[p-za-e][0-9a-f] doesn't seem to be good, IMHO.

In the case of the BSD sockets, the patch is not just an userless fix. This is
interesting when some applications are ported from other Unix'es and still uses BSD
pty's, since several other Unix flavors were defining a higher namespace size.

For example, on zOS Unix, a pty device seems to allow up to 10.000 pty numbers (in the
specific case of zOS Unix, they seem to be defined as /dev/[pt]typ[0-9]...) as shown at:
www.redbooks.ibm.com/redbooks/pdfs/sg245228.pdf

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/