Re: [PATCH] fix lock imbalances in /drivers/media/video/cafe_ccic.c

From: Daniel Walker
Date: Thu Sep 10 2009 - 10:48:29 EST


On Thu, 2009-09-10 at 18:37 +0000, iceberg wrote:
> In ./drivers/media/video/cafe_ccic.c, in function cafe_pci_probe:
> Mutex must be unlocked before exit
> 1. On paths starting with mutex lock in line 1912, then continuing in lines:
> 1929, 1936 (goto unreg) and 1940 (goto iounmap) .
> 2. On path starting in line 1971 mutex lock, and then continuing in line 1978
> (goto out_smbus) mutex.
>
> Fix lock imbalances in function cafe_pci_probe.
> Found by Linux Driver Verification project.

Could you run this through checkpatch and fix any issues you find? It
looks like you need to use tabs for indentation in a couple places.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/