[PATCH 2/2] x86: BUG(): use UNREACHABLE()

From: Roland McGrath
Date: Wed Sep 09 2009 - 22:06:06 EST


This uses the new UNREACHABLE() macro in x86's BUG() macro. In my
test builds, this saved 2022 bytes of text in vmlinux on x86_64,
3051 bytes on i686. (I didn't bother to calculate the additional
savings in .ko text.)

Signed-off-by: Roland McGrath <roland@xxxxxxxxxx>
CC: Jakub Jelinek <jakub@xxxxxxxxxx>
---
arch/x86/include/asm/bug.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/bug.h b/arch/x86/include/asm/bug.h
index d9cf1cd..a6458a3 100644
--- a/arch/x86/include/asm/bug.h
+++ b/arch/x86/include/asm/bug.h
@@ -22,14 +22,14 @@ do { \
".popsection" \
: : "i" (__FILE__), "i" (__LINE__), \
"i" (sizeof(struct bug_entry))); \
- for (;;) ; \
+ UNREACHABLE(); \
} while (0)

#else
#define BUG() \
do { \
asm volatile("ud2"); \
- for (;;) ; \
+ UNREACHABLE(); \
} while (0)
#endif

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/