Re: [PATCH] x86: SGU UV Add volatile to macros that access chipsetregisters

[H. Peter Anvin]

On 09/09/2009 12:38 PM, Jack Steiner wrote:
>  
>  static inline void uv_write_local_mmr8(unsigned long offset, unsigned char val)
>  {
> -	*((unsigned char *)uv_local_mmr_address(offset)) = val;
> +	*((volatile unsigned char *)uv_local_mmr_address(offset)) = val;
>  }
>  

Why aren't you simply using __writeb() here, and the other memory
accessors we already have in the other places?

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/